added Router Protocol adapter to the Hashi's pool of adapters #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allemanfredi
requested changes
Mar 21, 2024
| bytes memory requestMetadata = getRequestMetadata(); | ||
|
|
||
| uint256 iSendFee = ROUTER_GATEWAY.iSendDefaultFee(); | ||
| if (msg.value < iSendFee) revert InsufficientFeePassed(); |
There was a problem hiding this comment.
Unfortunately, this would break the integration with Yaho because it doesn't handle the distribution of msg.values among adapters. I suggest adding a payable function that accepts ETH so that a user can directly pay the adapter before calling Yaho.dispatchMessageToAdapters.
Basically, instead of checking the msg.value here, you can check the contract balance:
if (address(this).balance < iSendFee) revert ....
|
Added the suggested changes to the adapter @allemanfredi. Please review and merge. |
allemanfredi
requested changes
Mar 26, 2024
| return hex""; | ||
| } | ||
|
|
||
| function iAck(uint256, bool, bytes memory) external override { |
There was a problem hiding this comment.
This fx can be restricted to pure
|
Restricted it to pure. |
allemanfredi
approved these changes
Mar 26, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.