Add description to agent market (#308)

gnosis · Jul 12, 2024 · 3cb9487 · 3cb9487
1 parent 266b0bd
commit 3cb9487
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 3 deletions.
diff --git a/prediction_market_agent_tooling/markets/agent_market.py b/prediction_market_agent_tooling/markets/agent_market.py
@@ -47,6 +47,7 @@ class AgentMarket(BaseModel):
 
     id: str
     question: str
+    description: str | None
     outcomes: list[str]
     resolution: Resolution | None
     created_time: datetime | None

diff --git a/prediction_market_agent_tooling/markets/manifold/manifold.py b/prediction_market_agent_tooling/markets/manifold/manifold.py
@@ -13,11 +13,12 @@
 from prediction_market_agent_tooling.markets.manifold.api import (
     get_authenticated_user,
     get_manifold_binary_markets,
+    get_manifold_market,
     place_bet,
 )
 from prediction_market_agent_tooling.markets.manifold.data_models import (
     MANIFOLD_BASE_URL,
-    ManifoldMarket,
+    FullManifoldMarket,
 )
 from prediction_market_agent_tooling.tools.betting_strategies.minimum_bet_to_win import (
     minimum_bet_to_win,
@@ -58,10 +59,11 @@ def place_bet(self, outcome: bool, amount: BetAmount) -> None:
         )
 
     @staticmethod
-    def from_data_model(model: ManifoldMarket) -> "ManifoldAgentMarket":
+    def from_data_model(model: FullManifoldMarket) -> "ManifoldAgentMarket":
         return ManifoldAgentMarket(
             id=model.id,
             question=model.question,
+            description=model.textDescription,
             outcomes=model.outcomes,
             resolution=model.resolution,
             created_time=model.createdTime,
@@ -100,7 +102,7 @@ def get_binary_markets(
             raise ValueError(f"Unknown filter_by: {filter_by}")
 
         return [
-            ManifoldAgentMarket.from_data_model(m)
+            ManifoldAgentMarket.from_data_model(get_manifold_market(m.id))
             for m in get_manifold_binary_markets(
                 limit=limit,
                 sort=sort,

diff --git a/prediction_market_agent_tooling/markets/metaculus/metaculus.py b/prediction_market_agent_tooling/markets/metaculus/metaculus.py
@@ -25,6 +25,9 @@ class MetaculusAgentMarket(AgentMarket):
 
     have_predicted: bool
     base_url: t.ClassVar[str] = METACULUS_API_BASE_URL
+    description: str | None = (
+        None  # Metaculus markets don't have a description, so just default to None.
+    )
 
     @staticmethod
     def from_data_model(model: MetaculusQuestion) -> "MetaculusAgentMarket":

diff --git a/prediction_market_agent_tooling/markets/omen/omen.py b/prediction_market_agent_tooling/markets/omen/omen.py
@@ -91,6 +91,9 @@ class OmenAgentMarket(AgentMarket):
     )
 
     _binary_market_p_yes_history: list[Probability] | None = None
+    description: str | None = (
+        None  # Omen markets don't have a description, so just default to None.
+    )
 
     @property
     def yes_index(self) -> int:

diff --git a/prediction_market_agent_tooling/markets/polymarket/polymarket.py b/prediction_market_agent_tooling/markets/polymarket/polymarket.py
@@ -31,6 +31,7 @@ def from_data_model(model: PolymarketMarketWithPrices) -> "PolymarketAgentMarket
         return PolymarketAgentMarket(
             id=model.id,
             question=model.question,
+            description=model.description,
             outcomes=[x.outcome for x in model.tokens],
             resolution=model.resolution,
             current_p_yes=model.p_yes,

diff --git a/tests/markets/test_betting_strategies.py b/tests/markets/test_betting_strategies.py
@@ -143,6 +143,7 @@ def test_minimum_bet_to_win_manifold(
     min_bet = ManifoldAgentMarket(
         id="id",
         question="question",
+        description=None,
         outcomes=["Yes", "No"],
         current_p_yes=market_p_yes,
         created_time=utcnow() - timedelta(days=1),

diff --git a/tests/test_benchmark.py b/tests/test_benchmark.py
@@ -66,6 +66,7 @@ def test_benchmark_run(
     benchmarker = bm.Benchmarker(
         markets=[
             PolymarketAgentMarket(
+                description=None,
                 id="1",
                 volume=None,
                 url="url",
@@ -112,6 +113,7 @@ def test_benchmarker_cache(dummy_agent: DummyAgent) -> None:
         cache_path = f"{tmpdir}/cache.json"
         markets = [
             PolymarketAgentMarket(
+                description=None,
                 id="1",
                 volume=None,
                 url="url",
@@ -179,6 +181,7 @@ def test_benchmarker_cache(dummy_agent: DummyAgent) -> None:
 def test_benchmarker_cancelled_markets() -> None:
     markets = [
         PolymarketAgentMarket(
+            description=None,
             id="1",
             volume=None,
             url="url",
@@ -204,6 +207,7 @@ def test_benchmarker_cancelled_markets() -> None:
 def test_market_probable_resolution() -> None:
     with pytest.raises(ValueError) as e:
         PolymarketAgentMarket(
+            description=None,
             id="1",
             volume=None,
             url="url",
@@ -217,6 +221,7 @@ def test_market_probable_resolution() -> None:
     assert "Unknown resolution" in str(e)
     assert (
         PolymarketAgentMarket(
+            description=None,
             id="1",
             volume=None,
             url="url",
@@ -231,6 +236,7 @@ def test_market_probable_resolution() -> None:
     )
     assert (
         PolymarketAgentMarket(
+            description=None,
             id="1",
             volume=None,
             url="url",
@@ -245,6 +251,7 @@ def test_market_probable_resolution() -> None:
     )
     assert (
         PolymarketAgentMarket(
+            description=None,
             id="1",
             volume=None,
             url="url",
@@ -259,6 +266,7 @@ def test_market_probable_resolution() -> None:
     )
     assert (
         PolymarketAgentMarket(
+            description=None,
             id="1",
             volume=None,
             url="url",