-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send data along with xDai #566
Conversation
Warning Rate limit exceeded@kongzii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 18 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes introduce an optional parameter Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Web3
participant Transaction
User->>Web3: send_xdai_to(to_address, value, data_text)
Web3->>Transaction: Create transaction with value, to, data
Transaction-->>Web3: Transaction created
Web3-->>User: Transaction sent
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
tx_params: Optional[TxParams] = None, | ||
timeout: int = 180, | ||
) -> TxReceipt: | ||
from_address = private_key_to_public_key(from_private_key) | ||
|
||
tx_params_new: TxParams = {"value": value, "to": to_address} | ||
if data_text is not None: | ||
tx_params_new["data"] = Web3.to_bytes(text=data_text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR, just add an option to provide arbitrary text data into the transaction.
In PMA's PR, I'll use it in function like send_message
, decode_message
, etc., where zlib stuff will be used as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
prediction_market_agent_tooling/tools/web3_utils.py
(1 hunks)tests_integration_with_local_chain/markets/omen/test_local_chain.py
(1 hunks)
🔇 Additional comments (1)
prediction_market_agent_tooling/tools/web3_utils.py (1)
307-308
: Consider gas cost implications of data field
Adding data to transactions increases gas costs. Consider documenting this and potentially estimating the gas cost before proceeding.
Let's verify the gas cost implications:
No description provided.