Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug prints & bet only on one market hotfix #36

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

kongzii
Copy link
Contributor

@kongzii kongzii commented Mar 25, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced logging for the KnownOutcomeAgent, including detailed feedback on market selection, search query generation, and LLM prompts.

Copy link
Contributor

coderabbitai bot commented Mar 25, 2024

Warning

Rate Limit Exceeded

@kongzii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 41 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 57a1a0b and 6795bbd.

Walkthrough

The recent update involves enhancing the logging capabilities of the KnownOutcomeAgent within the prediction market agent project. Specifically, the modifications include adding print statements to better track the agent's decision-making process when selecting markets and to log the interaction with language models (LLMs), including the generation of search queries from LLM outputs. These changes aim to improve transparency and debugging efficiency by providing insights into the agent's operational dynamics and its use of external information.

Changes

File Path Change Summary
.../known_outcome_agent/deploy.py Updated logging with additional print statements, improved exception handling, and enhanced efficiency in market selection.
.../known_outcome_agent/known_outcome_agent.py Added print statements to log LLM prompts and the generated search queries before conducting web searches.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 14153e8 and bc6b37f.
Files selected for processing (2)
  • prediction_market_agent/agents/known_outcome_agent/deploy.py (1 hunks)
  • prediction_market_agent/agents/known_outcome_agent/known_outcome_agent.py (1 hunks)
Additional comments: 5
prediction_market_agent/agents/known_outcome_agent/deploy.py (3)
  • 40-40: The print statement before checking a market is clear and provides useful information for debugging purposes.
  • 47-49: The print statement for picking a market is informative, showing the market ID, question, and known outcome, which aids in understanding why a market was selected.
  • 53-56: The print statement for skipping a saturated market is clear and effectively communicates the reason for not selecting the market, which is crucial for debugging.
prediction_market_agent/agents/known_outcome_agent/known_outcome_agent.py (2)
  • 155-155: The print statement logging the LLM invocation prompt is clear and provides valuable insight into the inputs provided to the LLM, aiding in debugging and transparency.
  • 157-157: The print statement logging the search query generated from LLM output is informative, showing how the LLM's output is utilized for web searches, which is essential for understanding the agent's information gathering process.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between bc6b37f and 8950868.
Files selected for processing (1)
  • prediction_market_agent/agents/known_outcome_agent/deploy.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • prediction_market_agent/agents/known_outcome_agent/deploy.py

@kongzii kongzii self-assigned this Mar 26, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8950868 and 57a1a0b.
Files selected for processing (1)
  • prediction_market_agent/agents/known_outcome_agent/deploy.py (1 hunks)
Additional comments not posted (3)
prediction_market_agent/agents/known_outcome_agent/deploy.py (3)

39-39: Adding print statements enhances the visibility into the market evaluation process, aiding in debugging and understanding the agent's decision-making. This aligns with the PR's objective to improve debugging capabilities.


42-52: The addition of an exception handling block enhances the robustness of the market prediction process. It's good practice to log errors for debugging purposes. Consider defining specific exception types if predictable errors can occur, to provide more targeted error handling and recovery strategies.


60-63: The early return logic is a practical solution to the GCP Function timeout constraint. However, it's important to assess its impact on the agent's ability to participate in multiple markets. Consider testing or simulating scenarios to ensure this change doesn't unduly limit market participation.

@kongzii kongzii changed the title More prints to debug known outcome agent Debug prints & bet only on one market hotfix Apr 2, 2024
@kongzii kongzii merged commit c02be15 into main Apr 2, 2024
6 checks passed
@kongzii kongzii deleted the peter/more-prints-for-known-agent branch April 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants