Remove gas price from 0x and 1Inch requests #16
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not exceed any request limits for expensive DEX APIs there is an nginx egress proxy that caches requests to not waste RPS on identical requests.
This for example enables multiple API pods to only issue 1 actual request to the DEX API while receiving the response for all of them.
However, this currently only works if the requested URL is actually completely identical. So far the gas price got specified with the request which means whenever the gas price changes slightly caching will not be possible.
In order to switch to the dex solver being used as quoters in a colocated manner this has to be addressed.
Luckily 0x and 1Inch use reasonable default values for the gas price so we don't actually have to provide them and there is no nginx caching for balancer so we don't have to worry about that either.
Removes
gasPrice
from the requests and updates unit tests accordingly.