Set X-CURRENT-BLOCK-HASH header on every request
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests are fixed in the #19 |
m-lord-renkse
approved these changes
May 14, 2024
squadgazzz
approved these changes
May 14, 2024
|
🏓 @MartinquaXD to include before the automatic release cut... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new optional argument
current-block-poll-interval. When that is set we create aCurrentBlockStreamand use the current block hash to populate theX-CURRENT-BLOCK-HASHheader on every http request.I only made it optional to not have to introduce a bunch of mocking logic in tests for a minor feature.
Also updates dependencies to the backend crates with the exception of
solvers-dto. Upgrading that requires a bunch of changes in unit tests which are already covered in #19.