[TRIVIAL] Base: Add support for Balancer #90
Conversation
m-lord-renkse
changed the title
src/infra/dex/balancer/dto.rs
Outdated
| @@ -189,6 +189,7 @@ impl Chain { | |||
| eth::ChainId::Mainnet => Ok(Self::Mainnet), | |||
| eth::ChainId::Gnosis => Ok(Self::Gnosis), | |||
| eth::ChainId::ArbitrumOne => Ok(Self::Arbitrum), | |||
| eth::ChainId::Base => Ok(Self::Base), | |||
| unsupported => Err(Error::UnsupportedChainId(unsupported)), | |||
There was a problem hiding this comment.
Instead of using unsupported as the catch-all term we should probably explicitly list the unsupported networks. That way the compiler would have complained about the match statement here when you added the Base variant.
There was a problem hiding this comment.
This check was made for each request. So, I changed the parsing to be done at startup instead that for each request (which is inefficient). Now it should panic at startup if the network is not supported instead than throwing an error for each request.
There was a problem hiding this comment.
The actual comment was not addressed, though.
My point was to change the match statement to ensure that the compiler yells at us whenever we add a new chain. So in our case:
eth::ChainId::Goerli => Err(Error::UnsupportedChain(chain_id)),There was a problem hiding this comment.
Oh, sorry, I totally misunderstood you. On it!
There was a problem hiding this comment.
@MartinquaXD done! let me also know if you agree with the changes of making it as a startup error instead of parsing it for each request.
m-lord-renkse
force-pushed
the
base-add-to-balancer-dto
branch
from
918d9a8 to
5cfce9b
Compare
Add support for Balancer chain ID.
Add support for Balancer chain ID.