Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity check for eip 1559 #28

Closed
wants to merge 4 commits into from
Closed

sanity check for eip 1559 #28

wants to merge 4 commits into from

Conversation

debjit-bw
Copy link
Member

@debjit-bw debjit-bw commented Nov 4, 2024

sanity check script for eip 1559 (to ensure collector gets base fee and coinbase gets the effectivegas-basefee)

this PR includes a CI step which runs a couple txs and checks whether the collector address receives the base fees, and the coinbase receives the tip (effective gas minus base fee)

check the last few lines of the CI step here.

@debjit-bw debjit-bw changed the title check for eip 1559 sanity check for eip 1559 Nov 4, 2024
@debjit-bw debjit-bw marked this pull request as ready for review November 4, 2024 10:18
@debjit-bw debjit-bw requested a review from dapplion November 4, 2024 11:34
"prevRandao": "0x0000000000000000000000000000000000000000000000000000000000000000",
"receiptsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
"stateRoot": "0xa59f6ea19d9ee6d7e79bcb286e6d8838b47b48351b37960e24c0a72d41fa1629",
"stateRoot": "0xe65e8c7050e23e1f25c7f56416f899b1ce15ec130ee0460b12529b92b4a8ba81",
"timestamp": "0x6553f101",
"transactions": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No block have transactions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the blocks having txs are generated in the script themselves, closing this PR due to #30 (comment)

@debjit-bw debjit-bw closed this Nov 12, 2024
@dapplion
Copy link
Member

Closing in favor of:

Adding separate bash scripts for every test scales pretty bad. The scripts should result in producing a sequence of blocks from Nethermind with the engine API and then apply those blocks on Reth.

So you can have multiple generators, each generates a directory of block JSONs blocks_test_withdrawals_eip4895, then we have a script that you pass a blocks_ directory as argument and runs the test.

@debjit-bw debjit-bw deleted the sanity-checks branch December 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants