Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic change for withdrawals #31

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Logic change for withdrawals #31

merged 1 commit into from
Nov 13, 2024

Conversation

debjit-bw
Copy link
Member

This PR fixes the block building and block execution differences w.r.t. withdrawals:

  • system caller's post block logic removed (they call hardcoded eth mainnet deposit contract, while we have our own logic)
  • withdrawal and block consolidation calls removed (because we dont have eip 7251 yet)
  • withdrawals commitment involves just making the root, and not balance increments like commit_withdrawals does

@debjit-bw debjit-bw marked this pull request as ready for review November 12, 2024 03:50
@debjit-bw debjit-bw requested a review from dapplion November 12, 2024 03:50
@debjit-bw debjit-bw merged commit 7a1d49e into master Nov 13, 2024
6 checks passed
@debjit-bw debjit-bw deleted the lwithdrawals-fix branch November 13, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debjit-bw @dapplion