Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat - adds testing scripts for ethereum//tests and execution spec tests #37

Merged
merged 20 commits into from
Dec 5, 2024

Conversation

debjit-bw
Copy link
Member

@debjit-bw debjit-bw commented Dec 4, 2024

Adds necessary handlers and drivers for testing with ethereum/tests and the new eels tests.

  • We are skipping tests targeted at the following forks:
    • Frontier
    • Homestead
    • Byzantium
    • ByzantiumToConstantinopleAt5
    • Istanbul
    • Berlin
    • London
    • Constantinople
    • ConstantinopleFix
    • MergeEOF
    • MergeMeterInitCode
    • MergePush0

This DOES NOT mean that the features introduced at these forks are untested. Any feature introduced have tests targeted at all the forks after that, and we ARE testing for the fork "Merge" and later, skipping the ones before it.

  • We are directly using the tests generated for Ethereum, since we don't currently have the tests generated for Gnosis.
    • Therefore, several tests are failing, particularly 1559, withdrawals etc.
    • For most tests however, Gnosis and Mainnet work similarly.
    • 53 out of the 71 tests (combining eest and ethereum/tests) are PASSING. For now I have feature-gated the failing tests.
    • 18 tests are inside failing-tests feature (25%).

This PR is targeted mostly at setting up the code needed to run the EELS or ethereum tests. The tests themselves will be kept updated as and when Gnosis tests are available. The tests currently passing is just to prove that we aren't doing anything wildly wrong.

@debjit-bw debjit-bw requested a review from dapplion December 4, 2024 12:54
@debjit-bw debjit-bw marked this pull request as ready for review December 4, 2024 13:02
@debjit-bw debjit-bw changed the base branch from master to consistent-client-behaviour December 5, 2024 07:11
@debjit-bw debjit-bw changed the base branch from consistent-client-behaviour to master December 5, 2024 07:11
@debjit-bw debjit-bw changed the title Testing setup 2 feat - adds testing scripts for ethereum//tests and execution spec tests Dec 5, 2024
Copy link
Member

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you

@dapplion dapplion mentioned this pull request Dec 5, 2024
10 tasks
@debjit-bw debjit-bw merged commit d37780b into master Dec 5, 2024
7 checks passed
@debjit-bw debjit-bw deleted the testing-setup-2 branch December 5, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants