Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.1 #206

Merged
merged 44 commits into from
Dec 1, 2023
Merged

V2.1 #206

merged 44 commits into from
Dec 1, 2023

Conversation

cristovaoth
Copy link
Contributor

@cristovaoth cristovaoth commented Jun 30, 2023

  • Renaming: AbiEncoded to Calldata
    • The purpose of this change is to better reflect that it represents the encoded function invocation.
  • Introducing a new node: AbiEncoded
    • This node is used to represent parameters that contain abi.encode data.
    • Similar to Calldata, it allows the definition of conditions for nested and embedde nodes.
  • Relaxing TypeTree checks
    • The TypeTree checks have been relaxed to allow Dynamic nodes to be siblings of preceding AbiEncoded or Calldata nodes.
    • Subsequent Dynamic nodes can now be safely employed since they are considered equivalent, and won't count towards defining TypeTree used in decoding
  • Introducing a first example of a custom condition: AvatarIsOwnerOfERC721
    • Checks that the target address is an ERC721 contract and that the avatar owns the token ID specified as compValue
    • This condition is required for scoping Uniswap V3 NonfungiblePositionManager's increaseLiquidity/decreaseLiquidity
  • Make call target address and operation available to custom conditions
    • This change was required for implementing AvatarIsOwnerOfERC721
  • Allow allowance balance to be set to values exceeding the refill ceiling (maxBalance). Before we were unnecessarily restrictive about this.

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-roles-app ❌ Failed (Inspect) Dec 1, 2023 10:51am
zodiac-roles-docs ❌ Failed (Inspect) Dec 1, 2023 10:51am

@cristovaoth cristovaoth marked this pull request as draft June 30, 2023 12:06
@jfschwarz jfschwarz marked this pull request as ready for review August 22, 2023 12:38
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Pull Request Test Coverage Report for Build 7059012024

  • 65 of 66 (98.48%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 99.719%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/evm/contracts/AllowanceTracker.sol 8 9 88.89%
Totals Coverage Status
Change from base Build 5017089347: -0.3%
Covered Lines: 665
Relevant Lines: 666

💛 - Coveralls

@jfschwarz jfschwarz merged commit 6276d52 into main Dec 1, 2023
3 of 5 checks passed
@jfschwarz jfschwarz deleted the v2.1 branch December 1, 2023 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants