Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install gnopls and set GNOROOT #122

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

harry-hov
Copy link
Contributor

Latest version of vscode-gno uses gnopls to provide diagnostics and some code completion features.

Updated .gitpod.yml to install gnopls

Preview

ezgif com-optimize

@harry-hov harry-hov requested a review from thehowl September 24, 2023 19:45
@netlify
Copy link

netlify bot commented Sep 24, 2023

👷 Deploy request for gnochess pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 24170e1

@netlify
Copy link

netlify bot commented Sep 24, 2023

👷 Deploy request for gnochess-signup-form pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 24170e1

@thehowl
Copy link
Collaborator

thehowl commented Sep 25, 2023

thanks hariom! I'll take a look after sleeping (in ~9 hrs) first thing :)

@thehowl
Copy link
Collaborator

thehowl commented Sep 26, 2023

Mhh, I'm having some weird/funky behaviour with this.

Couple things that I notice which I think are bad for UX, just a few minutes of testing:

  • We pass on the precompile -> lint? error github.com/gnolang/gno/gnovm/stdlibs/stdshim and similar, this should be filtered out
  • I can't get things like the unused variable error that is in your video
  • Tried playing out with code, at one point I made a declaration which on save was being changed (x := "xx" -> x := "")

Think we might need for it to be slightly more stable, though I really do appreciate the effort!

@harry-hov
Copy link
Contributor Author

harry-hov commented Sep 26, 2023

Mhh, I'm having some weird/funky behaviour with this.

Couple things that I notice which I think are bad for UX, just a few minutes of testing:

  • We pass on the precompile -> lint? error github.com/gnolang/gno/gnovm/stdlibs/stdshim and similar, this should be filtered out

Language Server uses gno binary to provide errors (specifically gno precompile and gno build)

If we we want to filter out something maybe need to modify gno build

  • I can't get things like the unused variable error that is in your video

That's strange.

Again that error in video was from gno build. Maybe some problem with gno build

  • Tried playing out with code, at one point I made a declaration which on save was being changed (x := "xx" -> x := "")

Ah. Seems like there is some delay in language server onChange event.
If you type fast, you might lose few char onSave (due to latency). need to see how i can fix that

Think we might need for it to be slightly more stable, though I really do appreciate the effort!

I agree with you. It was implemented in rush.
Please look at PR #175. We might need to merge that one before workshop?

@harry-hov harry-hov self-assigned this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants