Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logqlengine): extract line filter pre-condition #169

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (4e0d085) 53.43% compared to head (c0e3a6c) 53.32%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   53.43%   53.32%   -0.11%     
==========================================
  Files         147      147              
  Lines       11169    11218      +49     
==========================================
+ Hits         5968     5982      +14     
- Misses       4955     4990      +35     
  Partials      246      246              
Files Coverage Δ
internal/logql/logqlengine/eval_streams.go 83.69% <100.00%> (ø)
internal/logql/logqlengine/precondition.go 91.42% <100.00%> (+5.71%) ⬆️
internal/logql/logqlengine/storage.go 100.00% <ø> (ø)
internal/ytstorage/ytql_querier_logs.go 0.00% <0.00%> (ø)
internal/ytstorage/yql_querier_logs.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota force-pushed the feat/line-filter-offload branch from 85ec26f to c0e3a6c Compare September 27, 2023 09:58
@tdakkota tdakkota marked this pull request as ready for review September 27, 2023 10:19
@tdakkota tdakkota merged commit 6cc232d into main Sep 27, 2023
14 checks passed
@tdakkota tdakkota deleted the feat/line-filter-offload branch September 27, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant