Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(chstorage): only query resource attributes for labels #554

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Nov 30, 2024

                                       │ benchstat.report.txt.old │         benchstat.report.txt         │
                                       │          sec/op          │    sec/op     vs base                │
LogQL/Lookup_by_materialzied_attribute               19.65m ± 17%   23.97m ± 31%        ~ (p=0.217 n=15)
LogQL/Lookup_by_regular_attribute                  7501.61m ±  1%   47.10m ± 22%  -99.37% (p=0.000 n=15)
geomean                                              384.0m         33.60m        -91.25%

                                       │ benchstat.report.txt.old │         benchstat.report.txt         │
                                       │        ch-sec/op         │  ch-sec/op    vs base                │
LogQL/Lookup_by_materialzied_attribute               12.67m ± 19%   12.43m ± 46%        ~ (p=0.436 n=15)
LogQL/Lookup_by_regular_attribute                  7499.13m ±  2%   44.70m ± 23%  -99.40% (p=0.000 n=15)
geomean                                              308.2m         23.57m        -92.35%

                                       │ benchstat.report.txt.old │          benchstat.report.txt           │
                                       │     ch-mem-bytes/op      │ ch-mem-bytes/op  vs base                │
LogQL/Lookup_by_materialzied_attribute               28.46Mi ± 0%     29.63Mi ± 15%   +4.12% (p=0.001 n=15)
LogQL/Lookup_by_regular_attribute                   284.53Mi ± 3%     31.90Mi ± 13%  -88.79% (p=0.000 n=15)
geomean                                              89.99Mi          30.75Mi        -65.83%

                                       │ benchstat.report.txt.old │           benchstat.report.txt           │
                                       │     ch-read-bytes/op     │ ch-read-bytes/op  vs base                │
LogQL/Lookup_by_materialzied_attribute               2.970Mi ± 0%       3.227Mi ± 0%   +8.64% (p=0.000 n=15)
LogQL/Lookup_by_regular_attribute                 745771.8Ki ± 0%       605.6Ki ± 0%  -99.92% (p=0.000 n=15)
geomean                                              46.51Mi            1.381Mi       -97.03%

                                       │ benchstat.report.txt.old │           benchstat.report.txt            │
                                       │     ch-read-rows/op      │ ch-read-rows/op  vs base                  │
LogQL/Lookup_by_materialzied_attribute                76.49k ± 0%       76.49k ± 0%        ~ (p=1.000 n=15) ¹
LogQL/Lookup_by_regular_attribute                  63630.02k ± 0%       10.89k ± 0%  -99.98% (p=0.000 n=15)
geomean                                               2.206M            28.86k       -98.69%
¹ all samples are equal

@tdakkota tdakkota force-pushed the perf/improve-label-lookup branch 2 times, most recently from acc5453 to 18a8e7e Compare November 30, 2024 08:11
```
                                       │      old       │                 new                  │
                                       │     sec/op     │    sec/op     vs base                │
LogQL/Lookup_by_materialzied_attribute     19.65m ± 17%   23.97m ± 31%        ~ (p=0.217 n=15)
LogQL/Lookup_by_regular_attribute        7501.61m ±  1%   47.10m ± 22%  -99.37% (p=0.000 n=15)
geomean                                    384.0m         33.60m        -91.25%
```
@tdakkota tdakkota force-pushed the perf/improve-label-lookup branch from 18a8e7e to 9b52dc8 Compare November 30, 2024 08:26
@ernado ernado changed the title perf(chstorage): use keys index for logs attributes perf(chstorage): only query resource attributes for labels Dec 4, 2024
@ernado ernado marked this pull request as ready for review December 4, 2024 00:44
@ernado ernado merged commit 43edb59 into main Dec 4, 2024
14 checks passed
@ernado ernado deleted the perf/improve-label-lookup branch December 4, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants