Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow LocalURL to be passed in the Host header #32555

Closed
wants to merge 1 commit into from
Closed

Allow LocalURL to be passed in the Host header #32555

wants to merge 1 commit into from

Conversation

jannispl
Copy link

@jannispl jannispl commented Nov 18, 2024 •
edited
Loading

Fix #32554

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 18, 2024
@wxiaoguang
Copy link
Contributor

LOCAL_ROOT_URL is only designed to be used by gitea's builtin commands, it is never expected to be used out of the local network.

In all cases, you should use ROOT_URL

@jannispl jannispl closed this Nov 19, 2024
@jannispl jannispl deleted the host-url-allow-internal branch November 19, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline Artifact API provides upload action with external app URL
3 participants
@jannispl @wxiaoguang @GiteaBot