-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo homepage tweaks #32759
base: main
Are you sure you want to change the base?
Repo homepage tweaks #32759
Conversation
Why I added See: |
Yes, that's why I increased the media query so it no longer shows like that. Long-term we should refactor from table to flexbox/grid because tables just suck for layouting. |
Hmm maybe this is dependant on font size or something. For me, the table limit was at 872px. |
@@ -24,7 +24,7 @@ | |||
border-top: 1px solid var(--color-secondary); /* same to .flex-list > .flex-item + .flex-item */ | |||
} | |||
|
|||
@media (max-width: 767.98px) { | |||
@media (max-width: 872px) { /* value is exactly where the file table starts to overflow */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would never believe such pixel-level fine-tuning could be right ......
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, but this table is a huge pixel hack to begin with, and tables are very hard to get responsive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I'm not sure I played around with these styles earlier and some of them didn't do anything. |
It should be like this: Fix repo home file list #32788 |
fixed
table layout. The non-fixed layout causes overflow issue between 872px and 768px width, fix that by switching to the mobile layout at 872px..repository-summary
to search bar in height: