Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gorm to master latest #242

Merged
merged 1 commit into from
Feb 5, 2024
Merged

update gorm to master latest #242

merged 1 commit into from
Feb 5, 2024

Conversation

black-06
Copy link
Contributor

@black-06 black-06 commented Feb 4, 2024

for go-gorm/gorm#6386

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

We must update gorm

User Case Description

Gorm must be upgraded, current v1.5.5 is not compatible.

It makes more sense to remove the tag.

Wait for the Gorm upgrade to complete, and then re-upgrade the postgres driver.

If we decide to do so, we can close this mr.

@jasonchuan
Copy link
Contributor

jasonchuan commented Feb 4, 2024

gorm dependency to driver is ok , driver dependency to gorm(except interface) is not best, choice,should we consider it more?

@black-06
Copy link
Contributor Author

black-06 commented Feb 4, 2024

gorm dependency to driver is ok ,but the implementation of driver dependency to gorm is not best, choice,should we consider it more?

I agree, but it seems that #195 must depends on go-gorm/gorm#6386, that's a breaking change, just like go-gorm/mysql#123.

But I foolishly forgot to remind jinzhu about this.

@black-06
Copy link
Contributor Author

black-06 commented Feb 4, 2024

I've deleted tag v1.5.5.
Next we need to discuss rollback, or how to fix it.

@black-06 black-06 requested a review from jinzhu February 4, 2024 11:05
@jasonchuan
Copy link
Contributor

I've deleted tag v1.5.5. Next we need to discuss rollback, or how to fix it.

We appreciate your hard work! we shoud fand another way to fix it ,it is not easy

@jinzhu jinzhu merged commit ae7e527 into go-gorm:master Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants