Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: distinguish between Unique and UniqueIndex (#195)" #248

Closed

Conversation

jasonchuan
Copy link
Contributor

@jasonchuan jasonchuan commented Feb 6, 2024

This reverts commit 1cfbc86.

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

we shoud revert the code ,and then add a tag v1.5.5 ,so that the issues can be resolved
#247
GenerateNU/sac#157
go-gorm/gorm#6821
etc

@jinzhu @black-06

User Case Description

@black-06
Copy link
Contributor

black-06 commented Feb 6, 2024

Then release a new version to retract v1.5.5?

retract (
    v1.5.5 // Published accidentally.
    v1.5.6 // Contains retractions only.
)

but we can do it directly on the current master.
the related code in GORM has been merged into the master, it means that even if #195 is revert now,
it still needs to merge into the master

@jasonchuan
Copy link
Contributor Author

Then release a new version to retract v1.5.5?

retract (
    v1.5.5 // Published accidentally.
    v1.5.6 // Contains retractions only.
)

but we can do it directly on the current master. the related code in GORM has been merged into the master, it means that even if #195 is revert now, it still needs to merge into the master

should go.mod go.sum should be revert at the same time !
to avaid accident ,we close this mr , consider it carefully before making decision.

@jasonchuan jasonchuan closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants