-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeating tasks in kanban views should be moved to the default bucket when done #347
Comments
Would love a patch. The update for ctrl-click is done here: which then triggers this function in the store: https://github.com/go-vikunja/vikunja/blob/main/frontend/src/stores/kanban.ts#L152-L176 That checks where to move the bucket. The api has the same logic and would need an update accordingly: https://github.com/go-vikunja/vikunja/blob/main/pkg/models/tasks.go#L993 |
Oh btw speaking of which: does the frontend build work for you currently? I tried to do it in a devenv-shell and it fails like this:
Can also reproduce this issue when updating the |
Nope, I have the same issue. Works in CI, maybe this is a problem with devenv. Dev watcher seem to work fine though (with |
It's not devenv-related, but a problem you'll always have with Nix:
|
Huh I thought this was statically linked |
Closes go-vikunja#347 The idea behind this is a kanban layout like this: | Backlog | In Progress | Done | A recurring task is also moved into `In Progress`, however when it's closed, it should be moved back into the default column (Backlog). This patch effectively implements that by changing the bucket ID in the saved view event hook for recurring tasks that were closed in the update action. The frontend counterpart gets a condition to detect this case and move the card to the right column in the UI. This patch is a POC to see if this goes into the right direction, most notably there's one part of the feature missing: I mostly care about the Ctrl-Click case, the "move to 'Done'" case doesn't work. I'm happy to implement that if the rest of the patch is fine for upstream.
Btw I fixed it like this in the Nix expression for vikunja, feel free to copy when the next release comes and the package in nixpkgs requires an update: diff --git a/pkgs/by-name/vi/vikunja/package.nix b/pkgs/by-name/vi/vikunja/package.nix
index 150b1abc8fb9..152238b62a16 100644
--- a/pkgs/by-name/vi/vikunja/package.nix
+++ b/pkgs/by-name/vi/vikunja/package.nix
@@ -28,6 +28,7 @@ let
doCheck = true;
postBuild = ''
+ find node_modules/.pnpm/sass-embedded-linux-*/node_modules/sass-embedded-linux-*/dart-sass/src -name dart -print0 | xargs -I {} -0 patchelf --set-interpreter "$(<$NIX_CC/nix-support/dynamic-linker)" {}
pnpm run build
'';
|
First iteration available as PR in gitea: https://kolaente.dev/vikunja/vikunja/pulls/2841 |
Closes go-vikunja#347 The idea behind this is a kanban layout like this: | Backlog | In Progress | Done | A recurring task is also moved into `In Progress`, however when it's closed, it should be moved back into the default column (Backlog). This patch effectively implements that by changing the bucket ID in the saved view event hook for recurring tasks that were closed in the update action. The frontend counterpart gets a condition to detect this case and move the card to the right column in the UI. This patch is a POC to see if this goes into the right direction, most notably there's one part of the feature missing: I mostly care about the Ctrl-Click case, the "move to 'Done'" case doesn't work. I'm happy to implement that if the rest of the patch is fine for upstream.
Closes go-vikunja#347 The idea behind this is a kanban layout like this: | Backlog | In Progress | Done | A recurring task is also moved into `In Progress`, however when it's closed, it should be moved back into the default column (Backlog). This patch effectively implements that by changing the bucket ID in the saved view event hook for recurring tasks that were closed in the update action. The frontend counterpart gets a condition to detect this case and move the card to the right column in the UI. This patch is a POC to see if this goes into the right direction, most notably there's one part of the feature missing: I mostly care about the Ctrl-Click case, the "move to 'Done'" case doesn't work. I'm happy to implement that if the rest of the patch is fine for upstream.
Description
So I have a saved filter that contains a bunch of tasks from different projects and has a relatively typical Kanban layout with an "In progress" & "Done" column (amongst others).
Now when moving a repeating task to "In progress" and doing ctrl-click when it's done, it doesn't make much sense to keep it in the
In Progress
column, instead I think it should go back into the default bucket.I started writing a patch that actually does that, however I still fail to tell the frontend that the bucket has changed (I don't really understand how
BucketID
is set to the correct bucket ID - that one's different depending on which view you're using, right), so perhaps there's a patch ready soonish. Would you be interested in such a patch?Vikunja Version
0.24.4
Browser and version
No response
Can you reproduce the bug on the Vikunja demo site?
Please select
Screenshots
No response
The text was updated successfully, but these errors were encountered: