Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Add quote policy support for table name and column name #1435

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 25, 2019

  • removed the syntax (id) support. This is a break change.
  • added SetTableQuotePolicy and SetColumnQuotePolicy on EngineInterface, this is also a break change for who implemented himself one.

Fix #1434

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #1435 into master will increase coverage by 0.27%.
The diff coverage is 68.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   56.88%   57.15%   +0.27%     
==========================================
  Files          48       49       +1     
  Lines        8190     8228      +38     
==========================================
+ Hits         4659     4703      +44     
+ Misses       2915     2908       -7     
- Partials      616      617       +1
Impacted Files Coverage Δ
helpers.go 58.98% <ø> (-0.75%) ⬇️
session_query.go 61.7% <0%> (ø) ⬆️
dialect_oracle.go 0% <0%> (ø) ⬆️
dialect_mssql.go 76.67% <100%> (+1.18%) ⬆️
dialect_sqlite3.go 80.7% <100%> (+1.31%) ⬆️
session_schema.go 57.72% <100%> (ø) ⬆️
engine_cond.go 56.29% <100%> (ø) ⬆️
session.go 58.49% <100%> (ø) ⬆️
xorm.go 70.58% <100%> (+2.4%) ⬆️
session_delete.go 58.22% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db25dfc...64dfdcb. Read the comment docs.

@lunny lunny force-pushed the lunny/quote_policy branch 2 times, most recently from ce6d21b to cac7688 Compare September 30, 2019 08:34
@lunny lunny force-pushed the lunny/quote_policy branch from 9a551b8 to 600a748 Compare October 1, 2019 06:46
@lunny lunny changed the title Add quote policy and quote mod support Add quote policy support for table name and column name Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oracle Dialect Quote Brackets
2 participants