Minor correction to rarely failed TestConnReaperDeadlock

The fix is similar to one of previous commit with deadlock fix
go-zeromq · Dec 14, 2023 · 2bf3109 · 2bf3109
1 parent 4fa0b49
commit 2bf3109
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/msgio.go b/msgio.go
@@ -64,11 +64,11 @@ func (q *qreader) Close() error {
 }
 
 func (q *qreader) addConn(r *Conn) {
-	go q.listen(q.ctx, r)
 	q.mu.Lock()
 	q.sem.enable()
 	q.rs = append(q.rs, r)
 	q.mu.Unlock()
+	go q.listen(q.ctx, r)
 }
 
 func (q *qreader) rmConn(r *Conn) {

diff --git a/pub.go b/pub.go
@@ -149,11 +149,11 @@ func (q *pubQReader) Close() error {
 }
 
 func (q *pubQReader) addConn(r *Conn) {
-	go q.listen(q.ctx, r)
 	q.mu.Lock()
 	q.sem.enable()
 	q.rs = append(q.rs, r)
 	q.mu.Unlock()
+	go q.listen(q.ctx, r)
 }
 
 func (q *pubQReader) rmConn(r *Conn) {

diff --git a/router.go b/router.go
@@ -119,11 +119,11 @@ func (q *routerQReader) Close() error {
 }
 
 func (q *routerQReader) addConn(r *Conn) {
-	go q.listen(q.ctx, r)
 	q.mu.Lock()
 	q.sem.enable()
 	q.rs = append(q.rs, r)
 	q.mu.Unlock()
+	go q.listen(q.ctx, r)
 }
 
 func (q *routerQReader) rmConn(r *Conn) {