Fix rep cancellation #143
Merged
Fix rep cancellation #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Msg): if the run() loop of repWriter has exited because r.ctx was cancelled then <- repSendPayload will block, because nobody is reading the channel anymore I'm adding a test that reproduces the issue with a fix.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 67.63% 67.42% -0.22%
==========================================
Files 29 29
Lines 2555 2560 +5
==========================================
- Hits 1728 1726 -2
- Misses 724 730 +6
- Partials 103 104 +1
☔ View full report in Codecov by Sentry. |
|
(apologies for the belated answer: holidays and the backlog from work...) thanks for the PR. could you send another PR against https://github.com/go-zeromq/license adding yourself to the |
|
Hey, thanks for your time. I added myself in this PR: go-zeromq/license#16 |
|
needs go-zeromq/license#16 |
|
thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a race condition in the ctx cancellation in
repWriter.Added a test which reproduces the issue with a possible fix.
I don't quite understand why dont we use
ctxin the write routine, see my second commit about that.