Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Sui blockchain support #173

Merged
merged 21 commits into from
Jan 4, 2025
Merged

feat: add Sui blockchain support #173

merged 21 commits into from
Jan 4, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

feat: add Sui blockchain support

This PR adds support for the Sui blockchain to the GOAT SDK:

  • Add Sui chain type to Chain.ts
  • Create Sui wallet package with abstract client
  • Implement SuiKeyPairWalletClient for keypair-based wallet operations
  • Add SendSUI plugin for token transfers

The implementation includes:

  • Full TypeScript support with proper types
  • Sui transaction handling
  • Balance queries
  • Object reading capabilities
  • Plugin for sending SUI tokens

Testing:

  • Code has been formatted according to project standards
  • Types are properly defined and checked
  • Linting issues have been addressed

Link to Devin run: https://app.devin.ai/sessions/1182e835c6b74be694bed4f7579de233

@devin-ai-integration @alfonso-paella
feat: add Sui blockchain support
086e913 
- Add Sui chain type to Chain.ts
- Create Sui wallet package with abstract client
- Implement SuiKeyPairWalletClient
- Add SendSUI plugin for token transfers

Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 36fd7a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

devin-ai-integration bot and others added 5 commits January 3, 2025 19:30
@devin-ai-integration @alfonso-paella
chore: regenerate pnpm-lock.yaml
c3d6fc0 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
chore: fix import organization in Sui wallet files
17aa01b 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
chore: regenerate pnpm-lock.yaml to include @types/node
f67101b 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
chore: add tsup config for sui wallet package
8324f49 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
chore: add tsconfig for sui wallet package
ec3e670 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
0xaguspunk
0xaguspunk requested changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@0xaguspunk 0xaguspunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, made some comments!

typescript/packages/wallets/sui/src/SuiKeyPairWalletClient.ts Outdated Show resolved Hide resolved
typescript/packages/wallets/sui/src/SuiKeyPairWalletClient.ts Outdated Show resolved Hide resolved
typescript/packages/wallets/sui/src/types.ts Outdated Show resolved Hide resolved
typescript/packages/wallets/sui/src/types.ts Show resolved Hide resolved
devin-ai-integration bot and others added 3 commits January 4, 2025 09:48
devin-ai-integration bot and others added 9 commits January 4, 2025 10:39
@devin-ai-integration @alfonso-paella
chore: update @mysten/sui.js to v0.54.1 and revert premature Transact…
fe7b3d3 
…ion class changes

Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
fix: update Sui transaction handling to use TransactionBlock
1e08bd6 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
chore: regenerate pnpm-lock.yaml
49f546d 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
fix: update Sui SDK imports to use dist/cjs paths
aab8111 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
fix: update formatting to match Biome linting rules
e964f98 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
docs: improve documentation and make transaction handling more generic
0f228ef 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@devin-ai-integration @alfonso-paella
style: remove extra whitespace in sendSui.plugin.ts
bc4ba32 
Co-Authored-By: Alfonso Gomez Jordana Manas <[email protected]>
@0xaguspunk
Fix PR
a21ca68
@0xaguspunk
Add changeset
36fd7a1
@0xaguspunk 0xaguspunk merged commit 50180d4 into main Jan 4, 2025
2 checks passed
@0xaguspunk 0xaguspunk deleted the devin/1735932034-add-sui-support branch January 4, 2025 11:46
@0xaguspunk 0xaguspunk mentioned this pull request Jan 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xaguspunk 0xaguspunk 0xaguspunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xaguspunk