Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount Radio #4749

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Mount Radio #4749

wants to merge 12 commits into from

Conversation

Jish2637
Copy link

@Jish2637 Jish2637 commented Nov 7, 2024

Simple plugin for FF XIV that lets you use a URL radio/live music stream whenever you mount up.

Audio stops when you dismount & will start/connect again when you mount up again.

Radio can also be toggled off/on at any time, mounted or on foot

/radiomount - Open settings

/radiovolume - 1-100 change the volume on the go.

/radiotoggle - toggle radio on/off anytime

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 7, 2024 •
edited
Loading

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@bleatbot bleatbot enabled auto-merge (squash) November 7, 2024 23:45
@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 9, 2024 •
edited
Loading

Outdated attempt

⚠️ No builds attempted! This probably means that your owners property is misconfigured.

Name Commit Status
👽 MountRadio [testing-live] 429f86d Not your plugin
Show log - Review

@bleatbot bleatbot added the new plugin This is a new plugin. label Nov 9, 2024
auto-merge was automatically disabled November 9, 2024 19:28

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 9, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
❌ MountRadio [testing-live] 429f86d Build failed (Diff)
12 Needs (⚠️ 1 UNREVIEWED)
Type Name Version Reviewed by
NuGet NAudio.WinForms 2.2.1 ⚠️ NEW
NuGet NAudio 2.2.1 reiichi001
NuGet Microsoft.NETCore.Platforms 3.1.0 reiichi001
NuGet Microsoft.Win32.Registry 4.7.0 reiichi001
NuGet NAudio.Asio 2.2.1 reiichi001
NuGet NAudio.Core 2.2.1 reiichi001
NuGet NAudio.Midi 2.2.1 reiichi001
NuGet NAudio.Wasapi 2.2.1 reiichi001
NuGet NAudio.WinMM 2.2.1 reiichi001
NuGet System.Security.AccessControl 4.7.0 reiichi001
NuGet System.Security.Principal.Windows 4.7.0 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 9, 2024
@Jish2637
Copy link
Author

Jish2637 commented Nov 9, 2024

I made a typo in the manifest & have corrected this

@Jish2637
Update manifest.toml
0adfefb 
latest commit, duplicate Dalamud.Plugin.targets import removed from csproj
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 10, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
❌ MountRadio [testing-live] 2536a52 Build failed (Diff)
12 Needs (⚠️ 1 UNREVIEWED)
Type Name Version Reviewed by
NuGet NAudio.WinForms 2.2.1 ⚠️ NEW
NuGet NAudio 2.2.1 reiichi001
NuGet Microsoft.NETCore.Platforms 3.1.0 reiichi001
NuGet Microsoft.Win32.Registry 4.7.0 reiichi001
NuGet NAudio.Asio 2.2.1 reiichi001
NuGet NAudio.Core 2.2.1 reiichi001
NuGet NAudio.Midi 2.2.1 reiichi001
NuGet NAudio.Wasapi 2.2.1 reiichi001
NuGet NAudio.WinMM 2.2.1 reiichi001
NuGet System.Security.AccessControl 4.7.0 reiichi001
NuGet System.Security.Principal.Windows 4.7.0 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@Felscream
Copy link
Contributor

I think you can just declare NAudio.Wasapi 2.2.1 as a dependency instead of NAudio if you are only using MediaFoundationReader. It should fix the error related to WinForms.

@Jish2637
Copy link
Author

I think you can just declare NAudio.Wasapi 2.2.1 as a dependency instead of NAudio if you are only using MediaFoundationReader. It should fix the error related to WinForms.

thank you very much for that, ill try now

@Jish2637
Update manifest.toml
7f626f0 
Updatad to use WasapiOut
Added option to toggle auto stop on dismount
Updated descriptions for plugin
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 10, 2024 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ MountRadio [testing-live] 96bc1f6 v0.0.0.1 - Repo (New plugin)
3 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet NAudio.Wasapi 2.2.1 reiichi001
NuGet NAudio.Core 2.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Nov 10, 2024
@Jish2637
Update manifest.toml
8b82224 
Updated Passenger Radio, removed function that was no longer needed.

Added toggle for radio autoplay in settings
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 10, 2024 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ MountRadio [testing-live] 421e62f v0.0.0.1 - Repo (New plugin)
3 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet NAudio.Wasapi 2.2.1 reiichi001
NuGet NAudio.Core 2.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@Jish2637
Copy link
Author

I have updated this to only use NAudio.Wasapi which has fixed the build error.

@reiichi001
Copy link
Contributor

Hi there! I've added this to our review queue. With FFXIV Patch 7.1 maintenance on the horizon, there may be breaking changes to come relatively soon.

A few notes from code review:

@Jish2637
Copy link
Author

Hi there! I've added this to our review queue. With FFXIV Patch 7.1 maintenance on the horizon, there may be breaking changes to come relatively soon.

A few notes from code review:

Hi reiichi,

Thank you very much for your feedback! I will implement the suggested edits as soon as I can.

@Jish2637
Update manifest.toml
bc75c89 
Merged configuration
corrected namespace in configuration.cs

Removed main window in favor of using the config window as the main GUI element
Merged content from main window into config window

Removed sample plugin traces from code

Implemented window helpers for scaled vector 2 sizes

Updated MountRadio.json description

Improved PlayRadio function to perform the radio initialization asynchronously, moving calls into a separate task so they don't interfere with the main thread.

Updated git readme
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 12, 2024 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ MountRadio [testing-live] f4230e0 v0.0.0.1 - Repo (New plugin)
3 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet NAudio.Wasapi 2.2.1 reiichi001
NuGet NAudio.Core 2.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@Jish2637
Copy link
Author

Jish2637 commented Nov 12, 2024 •
edited
Loading

Hi Reiichi,

I believe I have completed the suggested changes & I have put my commit notes in the manifest commit notes for reference.

Thanks in advance.

@goaaats
Copy link
Member

goaaats commented Nov 15, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 15, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
🚦 MountRadio [testing-live] f4230e0 Wrong API level! (have: 10, need: 11)
Show log - Review

@bleatbot bleatbot added version conflict This plugin was built with a lower or the same version. and removed size-large Diff for this PR is large. labels Nov 15, 2024
@Jish2637
Update manifest.toml
e9be75b 
Update For API 11
@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ MountRadio [testing-live] 80ea4d0 v0.0.0.1 - Repo (New plugin)
3 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet NAudio.Wasapi 2.2.1 reiichi001
NuGet NAudio.Core 2.2.1 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed version conflict This plugin was built with a lower or the same version. labels Nov 17, 2024
@reiichi001 reiichi001 added the completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. label Nov 17, 2024
@Jish2637
Copy link
Author

Hi,

I have tested with Dalamud 11.0.0 and can confirm everything is working as expected.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reiichi001 reiichi001

Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jish2637 @bleatbot @reiichi001 @Felscream @goaaats