Merge pull request #872 from qmhu/fix-rr-npe

fix rr controller npe
gocrane · Oct 24, 2023 · e29f4d6 · e29f4d6
2 parents 34ad4a4 + bb5c1e4
commit e29f4d6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/controller/recommendation/recommendation_rule_controller.go b/pkg/controller/recommendation/recommendation_rule_controller.go
@@ -215,9 +215,11 @@ func (c *RecommendationRuleController) doReconcile(ctx context.Context, recommen
 		for _, recommendation := range currRecommendations.Items {
 			exist := false
 			for _, id := range identitiesArray {
-				if recommendation.UID == id.Recommendation.UID {
-					exist = true
-					break
+				if id.Recommendation != nil {
+					if recommendation.UID == id.Recommendation.UID {
+						exist = true
+						break
+					}
 				}
 			}