Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the radio label not being set properly #2555

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

EvanHerman
Copy link
Contributor

Description

Fix the form block radio field not setting the field label properly. This effects the output in the email and what is displayed back to the user after form submission.

Screenshots

Before

image

After

image

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually tested.

Acceptance criteria

Ensure that radio fields have a label and no PHP warnings are displayed.

Checklist:

  • My code is tested
  • I've added proper labels to this pull request

@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Aug 10, 2023
@EvanHerman EvanHerman added this to the Next Release milestone Aug 10, 2023
@EvanHerman EvanHerman self-assigned this Aug 10, 2023
@AnthonyLedesma AnthonyLedesma removed this from the 3.1.2 milestone Aug 10, 2023
@AnthonyLedesma AnthonyLedesma merged commit e49fc47 into master Aug 10, 2023
10 of 199 checks passed
@AnthonyLedesma AnthonyLedesma deleted the fix-radio-label branch August 10, 2023 21:41
@AnthonyLedesma AnthonyLedesma added this to the 3.1.2 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Something new that adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants