Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom shortcut added #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

zoom shortcut added #116

wants to merge 1 commit into from

Conversation

AdityyaX
Copy link

@AdityyaX AdityyaX commented Feb 15, 2024

Hello @quozl ,
Could you please if possible, provide a direct link to the relevant section or instructions?

Comment on lines -71 to +73
"org.laptop.AbiWordActivity": "write.html"
"org.laptop.AbiWordActivity": "write.html",
"bundle_id": "org.laptop.WebActivity",
"zoom_in": "https://example.com/help/zoom_in.html"
Copy link
Contributor

@chimosky chimosky Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The browse activity helplink already exists and the pattern is "bundle_id": "file.html" not literally bundle_id.

Also we don't need to add a shortcut for zoom as there's no help page for zoom and rightly so.

@chimosky
Copy link
Contributor

chimosky commented Feb 15, 2024

Could you please if possible, provide a direct link to the relevant section or instructions?

The instructions are in html/ in the root directory of the repo, there are no external links to any as they were written and bundled with the activity.

@quozl
Copy link
Collaborator

quozl commented Feb 16, 2024

I've looked at this pull request but I don't understand your question or the patch you made, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants