Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information on web export splash color in custom HTML shells #10308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elpozewaunig
Copy link

This PR adds the mention of the new placeholder introduced in godotengine/godot#96625, which allows custom HTML shells to directly use the Project Settings splash color.

@elpozewaunig elpozewaunig changed the title Added information on web export splash color Added information on web export splash color in custom HTML shells Nov 22, 2024
@tetrapod00 tetrapod00 added this to the 4.4 milestone Nov 22, 2024
@tetrapod00 tetrapod00 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:export platform:web labels Nov 22, 2024
Additionally linked to project settings exposed as placeholder variables
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is not my specialty, however the original PR is very straightforward and this PR seems to correctly document it.

Style looks good.

@tetrapod00 tetrapod00 requested a review from a team November 23, 2024 00:15
@AThousandShips AThousandShips changed the title Added information on web export splash color in custom HTML shells Add information on web export splash color in custom HTML shells Nov 23, 2024
@tetrapod00
Copy link
Contributor

Also, thank you for coming back to document your changes in the online manual. The PR process only really requires that new changes be documented in the class reference, so new features go undocumented fairly often. Really appreciate the effort here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement platform:web topic:export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants