CI: Remove EOF fixer from pre-commit hook #10311
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this isn't enforced on the files used from the main engine repository, this currently seems more trouble than its worth.
mhilbrunner
added
bug
github_actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this isn't enforced on the files used from the main engine repository, this currently seems more trouble than its worth.
Notably, we got a build failure from #10309 due to the generated index for the classes:
diff --git a/classes/index.rst b/classes/index.rst index 5eb1dd9..74d350c 100644 --- a/classes/index.rst +++ b/classes/index.rst @@ -1088,4 +1088,3 @@ Variant types class_vector3i class_vector4 class_vector4i - Error: Process completed with exit code 1.We could re-add this in the future if we change this, however I'm not really convinced removing newlines from the end of files is useful.