-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed .0 from doc version drop down #414
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: PaarthAgarwal <[email protected]>
The versions are not hard coded and are taken from {{ $version := index (split .File.Path "/") 1 }}. Should I hardcode the version number instead of passing it like this? |
Signed-off-by: PaarthAgarwal <[email protected]>
I'm not sure if that's ok due to the fact we do versioning on the docs in branches, it breaks the links now |
https://deploy-preview-414--goharbor-io.netlify.app/ here is the address |
That's true. It breaks the links indeed |
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
@OrlinVasilev @Vad1mo |
@OrlinVasilev can you take a look at it again to see if it works for you? |
it works but it redirects to 2.7.0 again which is what we expect anyway! |
Signed-off-by: PaarthAgarwal [email protected]
Updates the config.toml file to display the version number without .0 in the drop-down.
Closes #219.