Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added style to add horizontal scrollbars on tables if are bigger #587

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

sergioarmgpl
Copy link
Contributor

Hi Harbor Community I added a style in the tables, with this change if the table width is big automatically adds an horizontal scrollbar. @OrlinVasilev

@Vad1mo
Copy link
Member

Vad1mo commented Oct 31, 2024

@sergioarmgpl, why not adding two screenshots a before and after one. This way everyone can instantly see the impovement. It is difficult for humans to apply css solely in their mind.

@sergioarmgpl
Copy link
Contributor Author

sergioarmgpl commented Nov 5, 2024

The improvements for this PR is that the information is more readable with the scroll bar, here is the comparison
Before it looked like this:

Screenshot 2024-11-05 at 15 33 51

After adding a default CSS style that adds an horizontal scroll bar if necessary it will look like this:

At the Top
Screenshot 2024-11-05 at 15 35 10

At the Bottom
Screenshot 2024-11-05 at 15 34 37

There are a lot of tables that have the same problem, so I added a CSS to all the tables, so all the tables will be fixed about this issue, a similar approach is currently used for CLI commands:
Screenshot 2024-11-05 at 15 39 59

cc: @Vad1mo @OrlinVasilev
PD: I also added this to the original issue #542

@sergioarmgpl
Copy link
Contributor Author

@OrlinVasilev @Vad1mo @steven-zou just looking if someone can approve my PR 😀

@Vad1mo Vad1mo enabled auto-merge (squash) November 19, 2024 09:02
@Vad1mo Vad1mo merged commit 4351854 into goharbor:main Nov 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants