Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches: restore signature of HashSign/HashVerify #199

Merged

Conversation

derekparker
Copy link
Contributor

The last patch restoring these functions modified the signature to match the new one exposed by openssl.HashSignECDSA and also the stdlib SignANS1/VerifyASN1 functions. This breaks consumers relying on the original API, so this patch restores that while using the new API under the hood.

Copy link
Collaborator

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 0cce198 into golang-fips:main May 23, 2024
6 checks passed
@derekparker derekparker deleted the wip/restore-hashsignverify-sig branch May 23, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants