Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load openssl if fips equals "1" #228

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dbenoit17
Copy link
Collaborator

This commit avoids loading openssl whenever GOLANG_FIPS is not 1. Previously only an unset variable would cause the library load to be skipped, but users may also expect to be able to set eg. GOLANG_FIPS=0 in environments without openssl.

This commit avoids loading openssl whenever GOLANG_FIPS is not 1.
Previously only an unset variable would cause the library load to
be skipped, but users may also expect to be able to set eg.
GOLANG_FIPS=0 in environments without openssl.
Copy link
Contributor

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@archanaravindar archanaravindar merged commit 9996b9c into golang-fips:main Sep 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants