Don't modify Go module version #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set the Go module toolchain version to an earlier version to allow running `go mod tidy` from older versions. However, this has the side effect of making the Go toolchain emulate older Go versions. This breaks some standard library tests which expect current toolchain behavior. To fix this, restore Go module toolchain version after tidy.
derekparker
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently set the Go module toolchain version to an earlier version to allow running
go mod tidyfrom older versions. However, this has the side effect of making the Go toolchain emulate older Go versions. This breaks some standard library tests which expect current toolchain behavior.Instead, do not modify the module version and instead use the new toolchain to run the
go mod ...steps, which is done via golang-fips/go#114.