dMatchUpSAKWithDecl: Fix treatment of invisible foralls without corresponding @-binders
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponding @-binders After this patch, `dMatchUpSAKWithDecl` is now able to handle a standalone kind signature with an invisible `forall` without a corresponding `@`-binder, as seen in the example below: ```hs type D :: forall (a :: Type). Type data D ``` While I was in town, I did some code cleanup in `dMatchUpSAKWithDecl` to make sure that all of the various error conditions are checked more thoroughly, documenting what parts of the code rely on which preconditions more precisely. I also applied the same treatment to `matchUpSAKWithDecl`. Fixes #228.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this patch,
dMatchUpSAKWithDeclis now able to handle a standalone kind signature with an invisibleforallwithout a corresponding@-binder, as seen in the example below:While I was in town, I did some code cleanup in
dMatchUpSAKWithDeclto make sure that all of the various error conditions are checked more thoroughly, documenting what parts of the code rely on which preconditions more precisely. I also applied the same treatment tomatchUpSAKWithDecl.Fixes #228.