Bug fixes in gateway #1157
Merged
Bug fixes in gateway #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsalthaj
commented
Dec 9, 2024
| .unwrap(); | ||
|
|
||
| assert_eq!(result, TypeAnnotatedValue::Str("foo, bar".to_string())); | ||
| } |
There was a problem hiding this comment.
Added these tests, but there are no bugs in logic
| impl GatewayBindingResolverError { | ||
| pub fn internal(err: &str) -> Self { | ||
| GatewayBindingResolverError::Internal(err.to_string()) | ||
| impl ErrorOrRedirect { |
There was a problem hiding this comment.
During the binding resolution phase itself (resolving a binding based on a http request, where the worker name is also resolved (Ex: worker-${request.auth.given_name})), middlewares such as authentication is applied, and can decide to redirect or not. That's the main change.
| let e = public_key.e().to_bytes_be(); | ||
| let kid = JsonWebKeyId::new("my-key-id".to_string()); | ||
| JsonWebKeySet::new(vec![CoreJsonWebKey::new_rsa(n, e, Some(kid))]) | ||
| }) |
There was a problem hiding this comment.
Now the test case is better, that the provider metadata will have the public key in it.
And the corresponding id_token will have its private key. Much easier to understand tests
noise64
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure worker name can look up athentication details, and not just response body.
JWKset were never serialized (its "skipped" in openidconnect library), and provider-metadata reuse for performance reasons resulted in signature mismatch errors. So now for claim verification, we discover the keyset on the fly, and is now consistently working.
2 test additions in Rib, which I thought was missing (but there is no bug here)
Here is a simple end user test with this api-definition, where both worker name and response mapping looks up authentication fields.