-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make running grpc api configurable #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem right to me - if the gRPC API is disabled, it does not create any of the internal services; but the goal is to have everything properly initialized (the result of create_services
) and just don't run the gRPC server itself.
So now this implements what the PR says (and what I hinted in the related task) but it won't really allow us to build an alternative server API on top of it. Basically it has the following issues:
So I propose the following implementation instead of the one in the PR:
|
Also made the service creation to a separate function for better readability