Fix Publishing changes from within view updates is not allowed, this …

…will cause undefined behavior. (#25) Co-authored-by: Andy Kayley <[email protected]>
gonzalezreal · Oct 28, 2022 · 0e811cb · 0e811cb
1 parent 87e90ed
commit 0e811cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Sources/AttributedText/AttributedText.swift b/Sources/AttributedText/AttributedText.swift
@@ -2,7 +2,8 @@ import SwiftUI
 
 /// A view that displays styled attributed text.
 public struct AttributedText: View {
-  @StateObject private var textSizeViewModel = TextSizeViewModel()
+  private var textSizeViewModel = TextSizeViewModel()
+  @State private var textSize: CGSize?
 
   private let attributedText: NSAttributedString
   private let onOpenLink: ((URL) -> Void)?
@@ -36,10 +37,13 @@ public struct AttributedText: View {
       )
     }
     .frame(
-      idealWidth: textSizeViewModel.textSize?.width,
-      idealHeight: textSizeViewModel.textSize?.height
+      idealWidth: textSize?.width,
+      idealHeight: textSize?.height
     )
     .fixedSize(horizontal: false, vertical: true)
+    .onReceive(textSizeViewModel.$textSize) { size in
+        textSize = size
+    }
   }
 }
 

diff --git a/Sources/AttributedText/TextSizeViewModel.swift b/Sources/AttributedText/TextSizeViewModel.swift
@@ -1,6 +1,6 @@
 import SwiftUI
 
-final class TextSizeViewModel: ObservableObject {
+final class TextSizeViewModel {
   @Published var textSize: CGSize?
 
   func didUpdateTextView(_ textView: AttributedTextImpl.TextView) {