Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update descriptions using LLM_descriptor tool #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janpansky
Copy link
Contributor

I have enhanced the layout with descriptions. I used simple GET and PUT. It worked well. However there are some minor things I'd like to validate.

For example:
"filterContextRef": {
"identifier": {
"id": "a4283267-0531-4b78-8faf-77faa5288811",
"type": "filterContext"
}
},
Was not present when GET. Is it ok to keep it removed?
Also:
"sourceColumnDataTypes": [
"TIMESTAMP"
],
"sourceColumns": [
"return_date"

vs
"sources": [
{
"column": "return_date",
"dataType": "TIMESTAMP",
"target": {
"id": "return_date",
"type": "date"
}
}

The rest of the changes are mostly positional. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant