Merge pull request #5512 from gooddata/fixFailedTestSDK

fix: stablize integrated tests
gooddata · Oct 24, 2024 · aec606b · aec606b
2 parents e66be92 + 72667fd
commit aec606b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/libs/sdk-ui-tests-e2e/cypress/integration/01-sdk-ui-dashboard/availableValueFilter.spec.ts b/libs/sdk-ui-tests-e2e/cypress/integration/01-sdk-ui-dashboard/availableValueFilter.spec.ts
@@ -124,7 +124,12 @@ describe("Available value filter", () => {
             .selectAttribute(["Cory Owens"])
             .apply();
 
-        widget.waitChartLoaded().getChart().getDataLabelValues().should("deep.equal", ["$2,376,100.41"]);
+        widget
+            .waitLoadStarted()
+            .waitChartLoaded()
+            .getChart()
+            .getDataLabelValues()
+            .should("deep.equal", ["$2,376,100.41"]);
 
         salesRepFilter.open().elementsAreLoaded().deleteFiltervaluesBy("Activity").hasFilterListSize(22);
     });

diff --git a/libs/sdk-ui-tests-e2e/cypress/integration/01-sdk-ui-dashboard/dependentFilters.spec.ts b/libs/sdk-ui-tests-e2e/cypress/integration/01-sdk-ui-dashboard/dependentFilters.spec.ts
@@ -247,8 +247,11 @@ describe("Dependent filter", () => {
             cy.intercept("GET", "**/attributes**").as("attributes");
             topBar.enterEditMode().editButtonIsVisible(false);
             product.open().selectAttributesWithoutApply("TouchAll").apply();
+            // open, close, then open to make sure that attribute filter on child is reloaded to correct valid elements
             cy.wait("@attributes").then(() => {
                 stageName
+                    .open()
+                    .close()
                     .open()
                     .elementsAreLoaded()
                     .hasNoRelevantMessage()
@@ -266,6 +269,8 @@ describe("Dependent filter", () => {
             new InsightsCatalog().waitForCatalogLoad();
             stateFilter.open().selectAttributesWithoutApply("Alabama").apply();
             cityFilter
+                .open()
+                .close()
                 .open()
                 .elementsAreLoaded()
                 .hasFilterListSize(5)
@@ -280,7 +285,7 @@ describe("Dependent filter", () => {
         topBar.enterEditMode().editButtonIsVisible(false);
         stateFilter.open().selectAttributesWithoutApply("Alabama").apply();
         cy.wait("@attributes").then(() => {
-            cityFilter.open().elementsAreLoaded().hasFilterListSize(5).close();
+            cityFilter.open().close().open().elementsAreLoaded().hasFilterListSize(5).close();
             stateFilter.removeFilter();
             cityFilter.isLoaded().open().elementsAreLoaded().hasFilterListSize(300);
         });
@@ -294,15 +299,15 @@ describe("Dependent filter", () => {
 
             topBar.enterEditMode().editButtonIsVisible(false);
             cy.wait("@attributes").then(() => {
-                cityFilter.open().selectAttribute(["Portland"]).apply();
+                cityFilter.open().selectAttribute(["Boston", "Nashua"]).apply();
             });
 
             stateFilter
                 .open()
                 .elementsAreLoaded()
                 .configureLimitingParentFilterDependency("City")
                 .hasFilterListSize(2)
-                .selectAttribute(["Oregon"])
+                .selectAttribute(["Massachusetts"])
                 .apply();
 
             stateFilter
@@ -313,7 +318,7 @@ describe("Dependent filter", () => {
                 .close();
 
             stateFilter.open().showAllElementValuesIsVisible(true);
-            table.waitLoaded().getColumnValues(1).should("deep.equal", ["Oregon"]);
+            table.waitLoaded().getColumnValues(1).should("deep.equal", ["Massachusetts"]);
         },
     );
 });
diff --git a/libs/sdk-ui-tests-e2e/cypress/tools/widget.ts b/libs/sdk-ui-tests-e2e/cypress/tools/widget.ts
@@ -18,6 +18,11 @@ export class Widget {
         return cy.get(this.getElementSelector());
     }
 
+    waitLoadStarted() {
+        this.getElement().find(".s-loading").should("exist");
+        return this;
+    }
+
     waitChartLoaded() {
         // it needs to see visualization-uri-root to know the chart loading
         this.getElement().find(".visualization-uri-root").should("exist");