fix: schedule list is missing Dashboard/Widget name

Schedule on List schedule dialog is missing Dashboard/Widget name risk: low JIRA: F1-930
gooddata · Nov 19, 2024 · b8ce7d8 · b8ce7d8
1 parent e3c6b47
commit b8ce7d8
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/libs/sdk-backend-tiger/src/convertors/fromBackend/ExportDefinitionsConverter.ts b/libs/sdk-backend-tiger/src/convertors/fromBackend/ExportDefinitionsConverter.ts
@@ -72,7 +72,7 @@ export const convertInlineExportDefinitionMdObject = (
         id,
         uri: id,
         ref: idRef(id, "exportDefinition"),
-        title: "",
+        title: (exportDefinitionOut.requestPayload.metadata as any).title ?? "",
         description: "",
         tags: [],
         requestPayload: request,

diff --git a/libs/sdk-backend-tiger/src/convertors/toBackend/AutomationConverter.ts b/libs/sdk-backend-tiger/src/convertors/toBackend/AutomationConverter.ts
@@ -78,10 +78,14 @@ export function convertAutomation(
 
     const tabularExports = exportDefinitions
         ?.filter((ed) => isExportDefinitionVisualizationObjectRequestPayload(ed.requestPayload))
-        .map((ed) => ({ requestPayload: convertExportDefinitionRequestPayload(ed.requestPayload) }));
+        .map((ed) => ({
+            requestPayload: convertExportDefinitionRequestPayload(ed.requestPayload, ed.title),
+        }));
     const visualExports = exportDefinitions
         ?.filter((ed) => isExportDefinitionDashboardRequestPayload(ed.requestPayload))
-        .map((ed) => ({ requestPayload: convertExportDefinitionRequestPayload(ed.requestPayload) }));
+        .map((ed) => ({
+            requestPayload: convertExportDefinitionRequestPayload(ed.requestPayload, ed.title),
+        }));
 
     const attributes = omitBy(
         {

diff --git a/libs/sdk-backend-tiger/src/convertors/toBackend/ExportDefinitionsConverter.ts b/libs/sdk-backend-tiger/src/convertors/toBackend/ExportDefinitionsConverter.ts
@@ -25,18 +25,29 @@ export const convertExportDefinitionMdObjectDefinition = (
                 title,
                 description,
                 tags,
-                requestPayload: convertExportDefinitionRequestPayload(requestPayload),
+                requestPayload: convertExportDefinitionRequestPayload(requestPayload, title),
             },
         },
     };
 };
 
 export const convertExportDefinitionRequestPayload = (
     exportRequest: IExportDefinitionRequestPayload,
+    title?: string,
 ): TabularExportRequest | VisualExportRequest => {
     if (isExportDefinitionDashboardRequestPayload(exportRequest)) {
         const { filters, dashboard } = exportRequest.content;
-        const metadataObj = exportRequest.content.filters ? { metadata: { filters } } : {};
+        const isMetadataFilled = title || exportRequest.content.filters;
+        const metadataObj = {
+            ...(isMetadataFilled
+                ? {
+                      metadata: {
+                          ...(exportRequest.content.filters ? { filters } : {}),
+                          ...(title ? { title } : {}),
+                      },
+                  }
+                : {}),
+        };
 
         return {
             fileName: exportRequest.fileName,
@@ -63,6 +74,7 @@ export const convertExportDefinitionRequestPayload = (
         },
         metadata: {
             widget,
+            ...(title ? { title } : {}),
         },
     } as TabularExportRequest;
 };