Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: LX-23 Introduce ability to configure attribute filter elements limits, support parent filters #4571

Merged
3 commits merged into from
Jan 24, 2024
Merged

FEATURE: LX-23 Introduce ability to configure attribute filter elements limits, support parent filters #4571

3 commits merged into from
Jan 24, 2024

Conversation

xMort
Copy link
Contributor

@xMort xMort commented Jan 22, 2024

Supported PR commands:

Command Description
ok to test Re-run standard checks
extended check sonar SonarQube tests
extended test - backstop BackstopJS tests
E2E Cypress tests commands - TIGER
extended test - tiger-cypress - isolated <testName> Run isolated tests running against recorded Tiger backend.
extended test - tiger-cypress - record <testName> Create a new recording for isolated Tiger tests.
extended test - tiger-cypress - integrated <testName> Run integrated tests against live backend
E2E Cypress tests commands - BEAR
extended test - cypress - isolated <testName> Run isolated tests running against recorded Bear backend.
extended test - cypress - record <testName> Create a new recording for isolated Bear tests.
extended test - cypress - integrated <testName> Run integrated tests against live backend
Compatibility matrix test commands - TIGER Backend
extended test - matrix-test <AIO_version> Run integrated tests against AIO versions.

<testName> in cypress commands is used to filter specfiles. Example, to run record with BEAR backend

  • Against dashboard.spec.ts and drilling.spec.ts, execute command extended test - cypress - record dashboard,drilling
  • Against all specfiles, execute command extended test - cypress - record or extended test - cypress - record *

<AIO_version> in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins build

  • To run with master and stable, execute command extended test - matrix-test master,stable or extended test - matrix-test latest
  • To run with specific version,ex: 2.3.0 and 2.3.1, execute command extended test - matrix-test 2.3.0,2.3.1
  • In case <AIO_version> is empty, read versions from file compTigerVersions.txt of this repo

PR Checklist

  • commit messages adhere to the commit message guidelines
  • review was done by a Code owner if necessary (if you think it is not necessary, explain the reasoning in the description or in a comment)
  • check passes
  • extended test - backstop passes
  • extended test - tiger-cypress - record to record new mapping files (Tiger BE)
  • extended test - cypress - record to record new mapping files (Bear BE)
  • extended test - tiger-cypress - isolated passes
  • extended test - cypress - isolated passes
  • extended test - tiger-cypress - integrated passes
  • rush change was run if applicable

@xMort xMort requested a review from kandl as a code owner January 22, 2024 15:52
@xMort xMort force-pushed the pdo-lx-23-refresh-after-state-update branch from d168023 to 9c2e826 Compare January 22, 2024 15:56
@ghost
Copy link

ghost commented Jan 22, 2024

Build in pipeline check aborted.

@ghost
Copy link

ghost commented Jan 22, 2024

Build failed (check pipeline).

@xMort xMort force-pushed the pdo-lx-23-refresh-after-state-update branch from 9c2e826 to 85953f2 Compare January 22, 2024 16:20
@ghost
Copy link

ghost commented Jan 22, 2024

Build succeeded (check pipeline).

@xMort xMort force-pushed the pdo-lx-23-refresh-after-state-update branch from 85953f2 to c572279 Compare January 22, 2024 16:51
@ghost
Copy link

ghost commented Jan 22, 2024

Build in pipeline check aborted.

@ivan-nejezchleb
Copy link
Contributor

LGTM

@yenkins
Copy link

yenkins commented Jan 22, 2024

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4571

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jan 22, 2024
@ghost
Copy link

ghost commented Jan 22, 2024

Build failed (gate pipeline).

@xMort xMort added the merge label Jan 22, 2024
@yenkins
Copy link

yenkins commented Jan 22, 2024

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4571

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jan 22, 2024
@ghost
Copy link

ghost commented Jan 22, 2024

Build failed (gate pipeline).

@xMort
Copy link
Contributor Author

xMort commented Jan 23, 2024

extended test - cypress - record *

@ghost
Copy link

ghost commented Jan 23, 2024

Build failed (check-extended pipeline).

@xMort xMort force-pushed the pdo-lx-23-refresh-after-state-update branch from c572279 to 54bda33 Compare January 23, 2024 13:02
@xMort
Copy link
Contributor Author

xMort commented Jan 23, 2024

extended test - cypress - isolated

@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check-extended pipeline).

@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check pipeline).

@xMort xMort force-pushed the pdo-lx-23-refresh-after-state-update branch from 4f0fc66 to 4f9d38c Compare January 23, 2024 13:21
@ghost
Copy link

ghost commented Jan 23, 2024

Build in pipeline check aborted.

@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check pipeline).

@xMort xMort force-pushed the pdo-lx-23-refresh-after-state-update branch from 4f9d38c to c545d5b Compare January 23, 2024 15:17
@xMort xMort changed the title FEATURE: LX-23 Introduce ability to configure attribute filter elements limits FEATURE: LX-23 Introduce ability to configure attribute filter elements limits, support parent filters Jan 23, 2024
@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check pipeline).

@xMort
Copy link
Contributor Author

xMort commented Jan 23, 2024

extended test - cypress - isolated

@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check-extended pipeline).

@ivan-nejezchleb
Copy link
Contributor

LGTM

@yenkins
Copy link

yenkins commented Jan 24, 2024

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4571

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jan 24, 2024
@ghost ghost merged commit d4d0e10 into gooddata:master Jan 24, 2024
7 checks passed
@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (gate pipeline).

@xMort xMort deleted the pdo-lx-23-refresh-after-state-update branch January 24, 2024 21:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nejezchleb ivan-nejezchleb ivan-nejezchleb approved these changes

@kandl kandl Awaiting requested review from kandl kandl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xMort @ivan-nejezchleb @yenkins