Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: F1-9 Rich text widget tests #4574

Merged
1 commit merged into from
Jan 24, 2024
Merged

FEATURE: F1-9 Rich text widget tests #4574

1 commit merged into from
Jan 24, 2024

Conversation

kandl
Copy link
Contributor

@kandl kandl commented Jan 23, 2024

Add basic tests for rich text widget.

JIRA: F1-9

Supported PR commands:

Command Description
ok to test Re-run standard checks
extended check sonar SonarQube tests
extended test - backstop BackstopJS tests
E2E Cypress tests commands - TIGER
extended test - tiger-cypress - isolated <testName> Run isolated tests running against recorded Tiger backend.
extended test - tiger-cypress - record <testName> Create a new recording for isolated Tiger tests.
extended test - tiger-cypress - integrated <testName> Run integrated tests against live backend
E2E Cypress tests commands - BEAR
extended test - cypress - isolated <testName> Run isolated tests running against recorded Bear backend.
extended test - cypress - record <testName> Create a new recording for isolated Bear tests.
extended test - cypress - integrated <testName> Run integrated tests against live backend
Compatibility matrix test commands - TIGER Backend
extended test - matrix-test <AIO_version> Run integrated tests against AIO versions.

<testName> in cypress commands is used to filter specfiles. Example, to run record with BEAR backend

  • Against dashboard.spec.ts and drilling.spec.ts, execute command extended test - cypress - record dashboard,drilling
  • Against all specfiles, execute command extended test - cypress - record or extended test - cypress - record *

<AIO_version> in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins build

  • To run with master and stable, execute command extended test - matrix-test master,stable or extended test - matrix-test latest
  • To run with specific version,ex: 2.3.0 and 2.3.1, execute command extended test - matrix-test 2.3.0,2.3.1
  • In case <AIO_version> is empty, read versions from file compTigerVersions.txt of this repo

PR Checklist

  • commit messages adhere to the commit message guidelines
  • review was done by a Code owner if necessary (if you think it is not necessary, explain the reasoning in the description or in a comment)
  • check passes
  • extended test - backstop passes
  • extended test - tiger-cypress - record to record new mapping files (Tiger BE)
  • extended test - cypress - record to record new mapping files (Bear BE)
  • extended test - tiger-cypress - isolated passes
  • extended test - cypress - isolated passes
  • extended test - tiger-cypress - integrated passes
  • rush change was run if applicable

@kandl kandl added the ready to review PR is ready to final code review label Jan 23, 2024
@kandl
Copy link
Contributor Author

kandl commented Jan 23, 2024

extended test - backstop

@kandl kandl changed the title FEATURE: F1-9 Rich text widget tests FEATURE: F1-9 Rich text widget tests Jan 23, 2024
@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check pipeline).

@yenkins
Copy link

yenkins commented Jan 23, 2024

Link to Storybook test result: https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-backstop-tests/2584/artifact/libs/sdk-ui-tests/backstop/output/html-report/index.html

@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check-extended pipeline).

@kandl kandl added do not merge Do not merge this yet and removed ready to review PR is ready to final code review labels Jan 23, 2024
@kandl
Copy link
Contributor Author

kandl commented Jan 23, 2024

extended test - tiger-cypress - record dashboardRichText

@ghost
Copy link

ghost commented Jan 23, 2024

Build failed (check-extended pipeline).

@ghost
Copy link

ghost commented Jan 23, 2024

Build succeeded (check pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 23, 2024

extended test - tiger-cypress - record dashboardRichText

@ghost
Copy link

ghost commented Jan 23, 2024

Build failed (check-extended pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 23, 2024

extended test - tiger-cypress - integrated dashboardRichText

@ghost
Copy link

ghost commented Jan 23, 2024

Build failed (check-extended pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 24, 2024

extended test - tiger-cypress - record dashboardRichText

@ghost
Copy link

ghost commented Jan 24, 2024

Build failed (check-extended pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 24, 2024

extended test - tiger-cypress - record

@ghost
Copy link

ghost commented Jan 24, 2024

Build failed (check-extended pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 24, 2024

extended test - tiger-cypress - record dashboardRichText

@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (check pipeline).

@ghost
Copy link

ghost commented Jan 24, 2024

Build failed (check-extended pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 24, 2024

extended test - tiger-cypress - record dashboardRichText

@yenkins
Copy link

yenkins commented Jan 24, 2024

Cypress recording succeeded 🎉

Here is your new recording: https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-cypress-tiger-record-zuul/156/artifact/libs/sdk-ui-tests-e2e/recordings/mappings/TIGER/*zip*/archive.zip

@yenkins
Copy link

yenkins commented Jan 24, 2024

✨ Cypress test results ✨

🎉 Great news! Tests were successful.

Status Name Tests Failures Time
✅ dashboardRichText.spec.ts 5(2 skipped) - 23.645s

You can find full report here.

@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (check-extended pipeline).

@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (check pipeline).

@scavnickyj
Copy link
Contributor

LGTM

@kandl
Copy link
Contributor Author

kandl commented Jan 24, 2024

extended test - tiger-cypress - isolated dashboardRichText

@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (check-extended pipeline).

@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (check pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 24, 2024

extended test - tiger-cypress - integrated dashboardRichText

@ghost
Copy link

ghost commented Jan 24, 2024

Build failed (check-extended pipeline).

@kandl
Copy link
Contributor Author

kandl commented Jan 24, 2024

extended test - tiger-cypress - integrated

@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (check-extended pipeline).

@kandl
feat(sdk-ui-dashboard): rich text widget tests
7af55ca 
Add basic tests for rich text widget.

Fix rendered markdown css.

Make react-app-template css more specific
to avoid css clash with rendered markdown.

JIRA: F1-9
@scavnickyj
Copy link
Contributor

LGTM

@scavnickyj scavnickyj added merge and removed do not merge Do not merge this yet labels Jan 24, 2024
@ghost
Copy link

ghost commented Jan 24, 2024

Build in pipeline check aborted.

@yenkins
Copy link

yenkins commented Jan 24, 2024

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4574

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jan 24, 2024
@ghost ghost merged commit f288c4b into gooddata:master Jan 24, 2024
3 of 4 checks passed
@ghost
Copy link

ghost commented Jan 24, 2024

Build succeeded (gate pipeline).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scavnickyj scavnickyj scavnickyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kandl @yenkins @scavnickyj