Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: F1-9 Rich text footer #4582

Merged
1 commit merged into from
Jan 23, 2024
Merged

Conversation

kandl
Copy link
Contributor

@kandl kandl commented Jan 23, 2024

Show footer when the rich text widget height is small. Before the fix it was hidden by overflow.

JIRA: F1-9


Supported PR commands:

Command Description
ok to test Re-run standard checks
extended check sonar SonarQube tests
extended test - backstop BackstopJS tests
E2E Cypress tests commands - TIGER
extended test - tiger-cypress - isolated <testName> Run isolated tests running against recorded Tiger backend.
extended test - tiger-cypress - record <testName> Create a new recording for isolated Tiger tests.
extended test - tiger-cypress - integrated <testName> Run integrated tests against live backend
E2E Cypress tests commands - BEAR
extended test - cypress - isolated <testName> Run isolated tests running against recorded Bear backend.
extended test - cypress - record <testName> Create a new recording for isolated Bear tests.
extended test - cypress - integrated <testName> Run integrated tests against live backend
Compatibility matrix test commands - TIGER Backend
extended test - matrix-test <AIO_version> Run integrated tests against AIO versions.

<testName> in cypress commands is used to filter specfiles. Example, to run record with BEAR backend

  • Against dashboard.spec.ts and drilling.spec.ts, execute command extended test - cypress - record dashboard,drilling
  • Against all specfiles, execute command extended test - cypress - record or extended test - cypress - record *

<AIO_version> in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins build

  • To run with master and stable, execute command extended test - matrix-test master,stable or extended test - matrix-test latest
  • To run with specific version,ex: 2.3.0 and 2.3.1, execute command extended test - matrix-test 2.3.0,2.3.1
  • In case <AIO_version> is empty, read versions from file compTigerVersions.txt of this repo

PR Checklist

  • commit messages adhere to the commit message guidelines
  • review was done by a Code owner if necessary (if you think it is not necessary, explain the reasoning in the description or in a comment)
  • check passes
  • extended test - backstop passes
  • extended test - tiger-cypress - record to record new mapping files (Tiger BE)
  • extended test - cypress - record to record new mapping files (Bear BE)
  • extended test - tiger-cypress - isolated passes
  • extended test - cypress - isolated passes
  • extended test - tiger-cypress - integrated passes
  • rush change was run if applicable

Show footer when the rich text widget height is small.
Before the fix it was hidden by overflow.

JIRA: F1-9
@kandl kandl added the ready to review PR is ready to final code review label Jan 23, 2024
@scavnickyj
Copy link
Contributor

LGTM

@ghost
Copy link

ghost commented Jan 23, 2024

Build in pipeline check aborted.

@yenkins
Copy link

yenkins commented Jan 23, 2024

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4582

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jan 23, 2024
@ghost ghost merged commit b9e5835 into gooddata:master Jan 23, 2024
3 of 4 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review PR is ready to final code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants