Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing design system #7

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Implementing design system #7

wants to merge 6 commits into from

Conversation

goodeats
Copy link
Owner

@goodeats goodeats commented Nov 8, 2023

This pull request implements a significant refactor of the current user interface architecture. It systematically removes all the individual UI components from our codebase and replaces them with imports from a newly established external component library.

Changes:

  • Removing local instances of UI components
  • Adding @pppaaattt/goodui as a dependency https://github.com/goodeats/goodui
  • Importing UI components from the external library to app/components directory
  • Exporting across all views from there so any changes are centrally located and don't need to change multiple files

Reasoning:

  1. Consistency: Centralizing UI components ensures that our applications have a uniform look and feel across the board
  2. Maintainability: Updates to UI components can be rolled out across all projects by updating a single library, reducing duplication of effort and potential for errors
  3. Development Speed: By abstracting the UI components, "our team" can focus on business logic and features rather than reinventing common UI patterns
  4. Collaboration: This approach facilitates "shared ownership" and easier collaboration with "teams" that may use or contribute to the UI component library
  5. Version Control: Handling UI components as a package allows "us" to version control design changes more effectively

@goodeats goodeats changed the title Goodui Implementing design system Nov 8, 2023
@goodeats
Copy link
Owner Author

goodeats commented Nov 8, 2023

Deleting the primitives seems to be causing problems in consistency of the UI
A button, field, etc is supposed to look identical from the component library as it does locally
Somehow deleting the primitives has an affect even though they are not being imported anywhere
Tough bug to figure out, going to set this down again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant