Port format-location to Typescript #4
Conversation
CamillaTeodoro
force-pushed
the
SLK-15-Port-format-location-to-Typescript
branch
from
473251f to
4ff0f3d
Compare
| "@babel/cli": "^7.22.5", | ||
| "@babel/core": "^7.22.5", | ||
| "@babel/polyfill": "^7.12.1", | ||
| "@babel/preset-env": "^7.22.5", | ||
| "@babel/preset-typescript": "^7.22.5", | ||
| "@babel/register": "^7.22.5", |
There was a problem hiding this comment.
Uff, we could use tsc to build this lib instead of depending on 6 libs only to run babel... something for the future!
lib/index.js
Outdated
There was a problem hiding this comment.
Why the lib code is being exported? 🤔 Is it for use in web browsers in minified versions?
There was a problem hiding this comment.
I'm not sure why, but this file has been exported since the repo was created.
I did a quick search in all Goodeggs repos and didn't find any imports from this folder.
| // Temporary entrypoint wrapper for various `yarn` scripts to configure @babel/register for TypeScript | ||
| // TODO(murkey) Remove this file and: | ||
| // - Use this wrapper: https://github.com/deepsweet/babel-register-ts | ||
| // - Get a new version of @babel/register with built-in support: https://github.com/babel/babel/pull/6027 | ||
| // - Get a version of babel that allows extensions to be configured via .babelrc/package.json: https://github.com/babel/babel/issues/3741 |
There was a problem hiding this comment.
Another reason to use only tsc? 🤷🏻
CamillaTeodoro
requested review from
guilherme-vp
and removed request for
guilherme-vp
CamillaTeodoro
force-pushed
the
SLK-15-Port-format-location-to-Typescript
branch
from
be79ddc to
01fde4c
Compare
|
@guilherme-vp I tried to update the repo to node 18, but the test is crashing in Travis. 
Looks like Travis is not configurated to run node 18. I found in https://travis-ci.community/t/node-lib-x86-64-linux-gnu-libm-so-6-version-glibc-2-27-not-found-required-by-node/13655 an explanation for the error. I think we should switch to node 18 when we move to Buildkite. |
Background
Story: https://goodeggs.atlassian.net/browse/SLK-15
In this PR we are migrating this repo from JS to TS following the instruction here: https://goodeggs.atlassian.net/wiki/spaces/ENG/pages/161841475/Porting+optionally+from+Flow+to+TypeScript
Changes