Make cache_length an argument from the Sampler
#70
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_708307065
branch
from
80685e1 to
3c46b31
Compare
copybara-service
bot
changed the title
cache_length an argument from the Sampler
copybara-service
bot
force-pushed
the
test_708307065
branch
from
3c46b31 to
399500e
Compare
`max_cache_length` is currently defined in the `TransformerConfig` but this really should be a sampler argument. * This would allow to use the same transformer instance for both training and inference. * From an API perspective, creating the Gemma configs for the 2b,... models should not require arguments. PiperOrigin-RevId: 712484211
copybara-service
bot
force-pushed
the
test_708307065
branch
from
399500e to
d03cfd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
cache_lengthan argument from the Samplermax_cache_lengthis currently defined in theTransformerConfigbut this really should be a sampler argument.