-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tuple of axis in softmax_cross_entropy_with_integer_labels
#1165
base: main
Are you sure you want to change the base?
Support tuple of axis in softmax_cross_entropy_with_integer_labels
#1165
Conversation
3c5e04e
to
9b7dde2
Compare
Hey, thanks! These PR looks great, I left some comments! |
JAX has an example of canonicalize_axis, we could vendor it from there (but it's a private API, so let's not import it from JAX directly) |
Yeah, I know of |
Makes sense, numpy's canonicalize are nice, but the import discrepancy between versions is a bit of a downside given potential API instability. Thanks for vendoring them! |
Fix #1162 (see #1164 for concurrent fix).