Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing Promises dependency in major version update #107

Closed
paulb777 opened this issue May 16, 2023 · 2 comments
Closed

Consider removing Promises dependency in major version update #107

paulb777 opened this issue May 16, 2023 · 2 comments
Assignees
@ncooke3
Milestone
GoogleUtilities 8...

Comments

@paulb777
Copy link
Member

The Promises dependency is currently broken on macOS because it hasn't yet updated from a 10.10 minimum version.

On closer look, the dependency seems heavyweight for a single public API that is used in just one place in Firebase.

In Firebase:

$ git grep gul_dataTaskPromiseWithRequest
FirebaseAppCheck/Sources/Core/APIService/FIRAppCheckAPIService.m:  return [self.URLSession gul_dataTaskPromiseWithRequest:request]
FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckAPIServiceTests.m:  OCMExpect([URLSessionMock gul_dataTaskPromiseWithRequest:URLRequestValidationArg])
@ncooke3 ncooke3 added this to the GoogleUtilities 8.0.0 milestone May 16, 2023
@mdmathias
Copy link

Filed an issue on PromisesObjC.

@ncooke3 ncooke3 self-assigned this Jun 7, 2024
@ncooke3 ncooke3 mentioned this issue Jun 11, 2024
Merged
@ncooke3
Copy link
Member

ncooke3 commented Jun 11, 2024

Done via #187. Will be released in v8.

@ncooke3 ncooke3 closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncooke3 ncooke3

Labels
None yet
Projects
None yet
Milestone
GoogleUtilities 8.0.0
Development

No branches or pull requests
3 participants
@paulb777 @mdmathias @ncooke3