Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Remove dependency on the Promises SDK #187

Merged
merged 7 commits into from
Jun 11, 2024
Merged

[v8] Remove dependency on the Promises SDK #187

merged 7 commits into from
Jun 11, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 11, 2024 •
edited
Loading

Everything has been reviewed in a previous PR, minus the changelog entry introduced in this PR.

Will be followed by a re-tag and re-stage.

Fix #107

paulb777
paulb777 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.62% (cb3d41f) to 0.13% (376e409) by -0.49%.

    FilenameBase (cb3d41f)Merge (376e409)Diff
    GULAppEnvironmentUtil.m3.23%3.42%+0.20%
    GULNetworkInfo.m23.86%0.00%-23.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lVPCH1s5Pl.html

@ncooke3 ncooke3 marked this pull request as ready for review June 11, 2024 16:28
@ncooke3 ncooke3 requested a review from andrewheard June 11, 2024 16:40
@ncooke3 ncooke3 mentioned this pull request Jun 11, 2024
Merged
@ncooke3 ncooke3 merged commit 2771466 into release-8.0 Jun 11, 2024
12 of 13 checks passed
@ncooke3 ncooke3 deleted the nc/remove-promises branch June 11, 2024 21:12
@ncooke3 ncooke3 mentioned this pull request Jun 11, 2024
Closed
@andrewheard andrewheard mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard